Lint additional four files in the tests folder#1708
Merged
lukpueh merged 4 commits intotheupdateframework:developfrom Dec 7, 2021
Merged
Lint additional four files in the tests folder#1708lukpueh merged 4 commits intotheupdateframework:developfrom
lukpueh merged 4 commits intotheupdateframework:developfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1582
Description of the changes being introduced by the pull request:
When preparing the pr which was going to resolve #1582 I had to rename the test files
related to the old codebase. That way I was able to exclude the old test files when linting
the
tests/folder.While I did that I realized I have to decide whether we want to lint and consequently rename
utils.py,test_utils.py,simple_server.py, andaggregate_tests.pyafter we remove the files testing the old code.I decided that it's worth linting them for the following reasons:
utils.pyprovides utilities that are used by our new code such as theTestServerProcessclasswhich handles server handling, logging, and the
run_sub_tests_with_datasetdecorator whichwe used in multiple files.
test_utils.pywill be needed even after we remove the old test files as we want to have teststhat verify that
TestServerProcessfromutils.pyis working as expectedsimple_server.pyis the only helper for server startup used in the new code base andmore precisely to start the server in
test_updater_ng.pyaggregate_tests.pywill be needed to aggregate the test filesThat's why I decided to run the linters upon those files.
I tried to summarize the manual changes I had to make in the commit messages
as they weren't many.
Most of the changes are automatic and are result from
blackandisort.Please verify and check that the pull request fulfills the following
requirements: